tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py - Issue 124733002: [Telemetry] Support downloading profiles from cloud storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 124733002: [Telemetry] Support downloading profiles from cloud storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't cache FindBrowser results since it breaks unit tests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

index 05f3c0908ffea7f65a7ff0bb54ae37aca2c817e9..2453b204f9ca05b8972a03fd48cbfabd62281c09 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

@@ -37,7 +37,9 @@ class PossibleWebDriverBrowser(possible_browser.PossibleBrowser):

"""A browser that can be controlled through webdriver API."""

def __init__(self, browser_type, finder_options):

- super(PossibleWebDriverBrowser, self).__init__(browser_type, finder_options)

+ target_os = sys.platform.lower()

+ super(PossibleWebDriverBrowser, self).__init__(browser_type, target_os,

+ finder_options)

assert browser_type in ALL_BROWSER_TYPES, \

'Please add %s to ALL_BROWSER_TYPES' % browser_type