Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/telemetry/telemetry/core/possible_browser.py

Issue 124733002: [Telemetry] Support downloading profiles from cloud storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't cache FindBrowser results since it breaks unit tests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/browser.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/possible_browser.py
diff --git a/tools/telemetry/telemetry/core/possible_browser.py b/tools/telemetry/telemetry/core/possible_browser.py
index 2d6ce66249e1f451bb46605d2b1729d1b5d3808a..07a0baa8ce9dd6e1c9772fb01f250e0d326d0b3d 100644
--- a/tools/telemetry/telemetry/core/possible_browser.py
+++ b/tools/telemetry/telemetry/core/possible_browser.py
@@ -7,8 +7,9 @@ class PossibleBrowser(object):
Call Create() to launch the browser and begin manipulating it..
"""
- def __init__(self, browser_type, finder_options):
+ def __init__(self, browser_type, target_os, finder_options):
self._browser_type = browser_type
+ self._target_os = target_os
self._finder_options = finder_options
def __repr__(self):
@@ -19,6 +20,11 @@ class PossibleBrowser(object):
return self._browser_type
@property
+ def target_os(self):
+ """Target OS, the browser will run on."""
+ return self._target_os
+
+ @property
def finder_options(self):
return self._finder_options
« no previous file with comments | « tools/telemetry/telemetry/core/browser.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698