Chromium Code Reviews

Issue 1245013003: QUIC - clean up changes to keep internal source and chromium code in sync. (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)
Modified:
5 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Protect_against_QUIC_crash_bug_98506577
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - clean up changes to keep internal source and chromium code in sync. + Comment update of quic_protocol.h. Merge internal change: 98669107 QUIC - minor cleanup of code in QuicConnection::OnAckFrame to handle incoming_ack.missing_packets.empty(). Fixed comments from internal CL: 98542855 (ian's review comments) relnote: n/a (don't increment stop_waiting_count_ if incoming_ack.missing_packets.empty and least_unacked > 0). Merge internal change: 98543739 Minor clean up of client.set_initial_max_packet_length in quic_client_bin and quic_simple_client_bin. R=rch@chromium.org Committed: https://crrev.com/bb2780cad4e11b3fdde2690428e90be003f5be73 Cr-Commit-Position: refs/heads/master@{#339928}

Patch Set 1 #

Patch Set 2 : Merge with TOT #

Unified diffs Side-by-side diffs Stats (+17 lines, -38 lines)
M net/quic/quic_connection.cc View 1 chunk +2 lines, -4 lines 0 comments
M net/quic/quic_protocol.h View 1 chunk +1 line, -1 line 0 comments
M net/tools/quic/end_to_end_test.cc View 9 chunks +9 lines, -18 lines 0 comments
M net/tools/quic/quic_client_bin.cc View 2 chunks +3 lines, -8 lines 0 comments
M net/tools/quic/quic_simple_client_bin.cc View 2 chunks +2 lines, -7 lines 0 comments

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 5 months ago (2015-07-20 22:48:50 UTC) #1
Ryan Hamilton
lgtm
5 years, 5 months ago (2015-07-22 18:06:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245013003/20001
5 years, 5 months ago (2015-07-22 18:09:14 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 19:16:14 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 19:17:43 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb2780cad4e11b3fdde2690428e90be003f5be73
Cr-Commit-Position: refs/heads/master@{#339928}

Powered by Google App Engine