Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: net/quic/quic_packet_creator.cc

Issue 1246793002: relnote: Protect against a QUIC crash bug but logging a DFATAL and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.cc
diff --git a/net/quic/quic_packet_creator.cc b/net/quic/quic_packet_creator.cc
index a8afaa7c4a31c0a89e941f95bdd7e3dd0deef7f5..7474b0b17b75bd1f3ebc8cea4b7f683583989e93 100644
--- a/net/quic/quic_packet_creator.cc
+++ b/net/quic/quic_packet_creator.cc
@@ -463,8 +463,11 @@ SerializedPacket QuicPacketCreator::SerializePacket(
packet.reset(framer_->BuildDataPacket(header, queued_frames_,
large_buffer.get(), packet_size_));
}
- LOG_IF(DFATAL, packet == nullptr) << "Failed to serialize "
- << queued_frames_.size() << " frames.";
+ if (packet == nullptr) {
+ LOG(DFATAL) << "Failed to serialize " << queued_frames_.size()
+ << " frames.";
+ return NoPacket();
+ }
OnBuiltFecProtectedPayload(header, packet->FecProtectedData());
« no previous file with comments | « no previous file | net/quic/quic_packet_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698