Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 12465017: fix erroring out on win x64 due to bad compiler version check (Closed)

Created:
7 years, 9 months ago by scottmg
Modified:
7 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5), ukai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

fix erroring out on win x64 due to bad compiler version check Compiler version of x64 compiler did not change at update 1. 'Helpfully', #error on the x64 compiler emits "unexpected end-of-file found" rather than something useful. :/ R=ukai@chromium.org TBR=cpu@chromium.org BUG=196438 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/win/win_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years, 9 months ago (2013-03-15 01:33:15 UTC) #1
ukai
lgtm
7 years, 9 months ago (2013-03-15 01:37:02 UTC) #2
scottmg
7 years, 9 months ago (2013-03-15 01:44:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r188241.

Powered by Google App Engine
This is Rietveld 408576698