base/win/win_util.cc - Issue 12465017: fix erroring out on win x64 due to bad compiler version check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/win_util.cc

Issue 12465017: fix erroring out on win x64 due to bad compiler version check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/win/win_util.cc

diff --git a/base/win/win_util.cc b/base/win/win_util.cc

index 8176bdd847a432499f268ef4b68cb81896c36737..81c3ee02f63e462addf3bad28758f789a48d6dfd 100644

--- a/base/win/win_util.cc

+++ b/base/win/win_util.cc

@@ -332,8 +332,8 @@ bool DismissVirtualKeyboard() {

#ifdef _MSC_VER

-// There are optimizer bugs in VS2012 pre-Update 1.

-#if _MSC_VER == 1700 && _MSC_FULL_VER < 170051106

+// There are optimizer bugs in x86 VS2012 pre-Update 1.

+#if _MSC_VER == 1700 && defined _M_IX86 && _MSC_FULL_VER < 170051106

#error Must install Update 1 to Visual Studio 2012.

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »