Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: base/win/win_util.cc

Issue 12465017: fix erroring out on win x64 due to bad compiler version check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/win_util.h" 5 #include "base/win/win_util.h"
6 6
7 #include <aclapi.h> 7 #include <aclapi.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <shlobj.h> 9 #include <shlobj.h>
10 #include <shobjidl.h> // Must be before propkey. 10 #include <shobjidl.h> // Must be before propkey.
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 return true; 325 return true;
326 } 326 }
327 return false; 327 return false;
328 } 328 }
329 329
330 } // namespace win 330 } // namespace win
331 } // namespace base 331 } // namespace base
332 332
333 #ifdef _MSC_VER 333 #ifdef _MSC_VER
334 334
335 // There are optimizer bugs in VS2012 pre-Update 1. 335 // There are optimizer bugs in x86 VS2012 pre-Update 1.
336 #if _MSC_VER == 1700 && _MSC_FULL_VER < 170051106 336 #if _MSC_VER == 1700 && defined _M_IX86 && _MSC_FULL_VER < 170051106
337 #error Must install Update 1 to Visual Studio 2012. 337 #error Must install Update 1 to Visual Studio 2012.
338 #endif 338 #endif
339 339
340 #endif // _MSC_VER 340 #endif // _MSC_VER
341 341
342 #ifndef COPY_FILE_COPY_SYMLINK 342 #ifndef COPY_FILE_COPY_SYMLINK
343 #error You must install the Windows 2008 or Vista Software Development Kit and \ 343 #error You must install the Windows 2008 or Vista Software Development Kit and \
344 set it as your default include path to build this library. You can grab it by \ 344 set it as your default include path to build this library. You can grab it by \
345 searching for "download windows sdk 2008" in your favorite web search engine. \ 345 searching for "download windows sdk 2008" in your favorite web search engine. \
346 Also make sure you register the SDK with Visual Studio, by selecting \ 346 Also make sure you register the SDK with Visual Studio, by selecting \
347 "Integrate Windows SDK with Visual Studio 2005" from the Windows SDK \ 347 "Integrate Windows SDK with Visual Studio 2005" from the Windows SDK \
348 menu (see Start - All Programs - Microsoft Windows SDK - \ 348 menu (see Start - All Programs - Microsoft Windows SDK - \
349 Visual Studio Registration). 349 Visual Studio Registration).
350 #endif 350 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698