Issue 1246103005: Add GN data/data_deps logic for some test binaries.

Issue 1246103005: Add GN data/data_deps logic for some test binaries. (Closed)

Created:
5 years, 5 months ago by Dirk Pranke

Modified:
5 years, 5 months ago

Reviewers:
brettw, M-A Ruel, sky

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@rework_mb_swarming

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add GN data/data_deps logic for some test binaries. This adds the data and data_deps logic for ui_base_unittests and cacheinvalidation_unittests for the GN build, so that we can run those two binaries under swarming. R=sky@chromium.org, brettw@chromium.org, maruel@chromium.org BUG=504079 Committed: https://crrev.com/bfb8da32603b8f9ba753cc1052685ec57b8f7e2c Cr-Commit-Position: refs/heads/master@{#339829}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -3 lines)			Patch
M	testing/buildbot/chromium.linux.json	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/cacheinvalidation/BUILD.gn	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View	4 chunks	+42 lines, -3 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246103005/1

5 years, 5 months ago (2015-07-22 01:09:44 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 03:44:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bfb8da32603b8f9ba753cc1052685ec57b8f7e2c
Cr-Commit-Position: refs/heads/master@{#339829}