Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1248673005: Add GN isolate support for a bunch of unittests. (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
Reviewers:
brettw, M-A Ruel, dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, rickyz+watch_chromium.org, yuzo+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Ian Vollick, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@some_isolates
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN isolate support for a bunch of unittests. This enables the following tests to be run under swarming on a GN bot: - angle_unittests - accessibility_unittests - compositor_unittests - cc_unittests - ipc_tests - gl_unittests - sandbox_linux_unittests - gn_unittests - skia_unittests - sql_unittests - url_unittests R=brettw@chromium.org, maruel@chromium.org BUG=504079 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Committed: https://crrev.com/177c1e29c1abeb267b3ab1283a4c7c03a398ec6f Cr-Commit-Position: refs/heads/master@{#339973}

Patch Set 1 : initial patch for review #

Patch Set 2 : merge to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -11 lines) Patch
M cc/BUILD.gn View 1 3 chunks +15 lines, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M sql/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 8 chunks +16 lines, -11 lines 0 comments Download
M tools/gn/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download
M url/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Dirk Pranke
5 years, 5 months ago (2015-07-21 22:58:36 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-21 23:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248673005/20001
5 years, 5 months ago (2015-07-22 16:29:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/76309) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-22 16:31:08 UTC) #7
M-A Ruel
lgtm, thanks!
5 years, 5 months ago (2015-07-22 18:16:22 UTC) #8
dmazzoni
lgtm for ui/accessibility, and thanks!
5 years, 5 months ago (2015-07-22 18:29:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248673005/40001
5 years, 5 months ago (2015-07-22 20:36:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/60768) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-22 21:03:04 UTC) #15
Adrian Kuegel
On 2015/07/22 20:36:12, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 5 months ago (2015-07-22 21:03:05 UTC) #16
Adrian Kuegel
On 2015/07/22 21:03:05, Adrian Kuegel wrote: > On 2015/07/22 20:36:12, commit-bot: I haz the power ...
5 years, 5 months ago (2015-07-22 21:03:29 UTC) #17
Dirk Pranke
On 2015/07/22 21:03:29, Adrian Kuegel wrote: > On 2015/07/22 21:03:05, Adrian Kuegel wrote: > > ...
5 years, 5 months ago (2015-07-22 21:05:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248673005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248673005/40001
5 years, 5 months ago (2015-07-22 21:36:55 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-22 23:07:50 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 23:09:09 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/177c1e29c1abeb267b3ab1283a4c7c03a398ec6f
Cr-Commit-Position: refs/heads/master@{#339973}

Powered by Google App Engine
This is Rietveld 408576698