Sync: Don't set/use Parent ID for non-hierarchical sync data types.

Sync: Don't set/use Parent ID for non-hierarchical sync data types.

1) When creating a new non-hierarchical sync entry
bookmarks, don't set Parent ID field anymore.

2) When processing an update for a non-hierarchical sync entry,
ignore the parent ID in the update message and set
empty parent ID instead.

This will prepare the client for a server transition to
implicit permanent folders and save some memory by not
storing two IDs (~300-350 bytes) per entry.

BUG=514854
Committed: https://crrev.com/6d2f3f06756f8157e0ebe5ae2142e706c2837394
Cr-Commit-Position: refs/heads/master@{#341209}

[stanisc, 2015-07-28 22:24:10]

stanisc@chromium.org changed reviewers:
+ zea@chromium.org

[stanisc, 2015-07-28 22:24:11]

Please take a look.

[Nicolas Zea, 2015-07-29 17:58:09]

zea@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Nicolas Zea, 2015-07-29 17:58:09]

+Max FYI

LGTM with a nit

https://codereview.chromium.org/1246063003/diff/1/sync/engine/syncer_proto_ut...
File sync/engine/syncer_proto_util.cc (right):

https://codereview.chromium.org/1246063003/diff/1/sync/engine/syncer_proto_ut...
sync/engine/syncer_proto_util.cc:541: sync_entity.parent_id_string() == "0";
nit: why check parent id string rather than model type == TOP_LEVEL_FOLDER

[stanisc, 2015-07-29 21:37:07]

https://codereview.chromium.org/1246063003/diff/1/sync/engine/syncer_proto_ut...
File sync/engine/syncer_proto_util.cc (right):

https://codereview.chromium.org/1246063003/diff/1/sync/engine/syncer_proto_ut...
sync/engine/syncer_proto_util.cc:541: sync_entity.parent_id_string() == "0";
On 2015/07/29 17:58:09, Nicolas Zea wrote:
> nit: why check parent id string rather than model type == TOP_LEVEL_FOLDER

This is for compatibility with some tests that create non-folder items at the
top level.

[stanisc, 2015-07-30 21:39:39]

The CQ bit was checked by stanisc@chromium.org

[commit-bot: I haz the power, 2015-07-30 21:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1246063003/1

[commit-bot: I haz the power, 2015-07-30 22:29:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-30 22:29:39]

Patchset 1 (id:??) landed as
https://crrev.com/6d2f3f06756f8157e0ebe5ae2142e706c2837394
Cr-Commit-Position: refs/heads/master@{#341209}