Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Unified Diff: chrome/browser/sync/glue/typed_url_change_processor.cc

Issue 1246063003: Sync: Don't set/use Parent ID for non-hierarchical sync data types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_change_processor.cc
diff --git a/chrome/browser/sync/glue/typed_url_change_processor.cc b/chrome/browser/sync/glue/typed_url_change_processor.cc
index 48455b81fbaa33a76521d0d41a8deef9927a4f2b..8170ce56e979dc6913cd45507255d1b122f3a72d 100644
--- a/chrome/browser/sync/glue/typed_url_change_processor.cc
+++ b/chrome/browser/sync/glue/typed_url_change_processor.cc
@@ -166,17 +166,6 @@ bool TypedUrlChangeProcessor::CreateOrUpdateSyncNode(
// This URL has no TYPED visits, don't sync it.
return false;
- syncer::ReadNode typed_url_root(trans);
- if (typed_url_root.InitTypeRoot(syncer::TYPED_URLS) !=
- syncer::BaseNode::INIT_OK) {
- syncer::SyncError error(FROM_HERE,
- syncer::SyncError::DATATYPE_ERROR,
- "No top level folder",
- syncer::TYPED_URLS);
- error_handler()->OnSingleDataTypeUnrecoverableError(error);
- return false;
- }
-
if (model_associator_->ShouldIgnoreUrl(url.url()))
return true;
@@ -197,8 +186,7 @@ bool TypedUrlChangeProcessor::CreateOrUpdateSyncNode(
} else {
syncer::WriteNode create_node(trans);
syncer::WriteNode::InitUniqueByCreationResult result =
- create_node.InitUniqueByCreation(syncer::TYPED_URLS,
- typed_url_root, tag);
+ create_node.InitUniqueByCreation(syncer::TYPED_URLS, tag);
if (result != syncer::WriteNode::INIT_SUCCESS) {
syncer::SyncError error(FROM_HERE,
« no previous file with comments | « no previous file | chrome/browser/sync/glue/typed_url_model_associator.cc » ('j') | sync/engine/syncer_proto_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698