chrome/browser/sync/profile_sync_service_typed_url_unittest.cc - Issue 1246063003: Sync: Don't set/use Parent ID for non-hierarchical sync data types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

Issue 1246063003: Sync: Don't set/use Parent ID for non-hierarchical sync data types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_autofill_unittest.cc ('k') | components/sync_driver/generic_change_processor.cc » ('j') | sync/engine/syncer_proto_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

index e469b5c147b4b3c964ec157944fa8913fb7bd9db..9383e409df2a5ec41d335f8e01c4558dd41ebbde 100644

--- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

@@ -209,14 +209,11 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest {

void AddTypedUrlSyncNode(const history::URLRow& url,

const history::VisitVector& visits) {

syncer::WriteTransaction trans(FROM_HERE, sync_service_->GetUserShare());

- syncer::ReadNode typed_url_root(&trans);

- ASSERT_EQ(syncer::BaseNode::INIT_OK,

- typed_url_root.InitTypeRoot(syncer::TYPED_URLS));

syncer::WriteNode node(&trans);

std::string tag = url.url().spec();

syncer::WriteNode::InitUniqueByCreationResult result =

- node.InitUniqueByCreation(syncer::TYPED_URLS, typed_url_root, tag);

+ node.InitUniqueByCreation(syncer::TYPED_URLS, tag);

ASSERT_EQ(syncer::WriteNode::INIT_SUCCESS, result);

TypedUrlModelAssociator::WriteToSyncNode(url, visits, &node);

}