Add logic to parse "data:" URLs to RoundedIconGenerator.java

Add logic to parse "data:" URLs to RoundedIconGenerator.java

BUG=505430
Committed: https://crrev.com/242275ead23a63870c066023144c58762d882427
Cr-Commit-Position: refs/heads/master@{#339769}

[Theresa, 2015-07-21 17:35:42]

twellington@chromium.org changed reviewers:
+ newt@chromium.org

[Theresa, 2015-07-21 17:35:43]

ptal

[newt (away), 2015-07-21 17:41:25]

https://codereview.chromium.org/1245233002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
(right):

https://codereview.chromium.org/1245233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java:195:
return null;
Rather than explicitly handling data: URIs, how about just changing the fallback
case (i.e. line 195) to return the first character of the URL, rather than null.
That'll also address other weird cases that we haven't yet anticipated, e.g.
file:// URLs.

[Theresa, 2015-07-21 17:52:22]

https://codereview.chromium.org/1245233002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
(right):

https://codereview.chromium.org/1245233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java:195:
return null;
On 2015/07/21 17:41:25, newt wrote:
> Rather than explicitly handling data: URIs, how about just changing the
fallback
> case (i.e. line 195) to return the first character of the URL, rather than
null.
> That'll also address other weird cases that we haven't yet anticipated, e.g.
> file:// URLs.

Done.

[newt (away), 2015-07-21 17:53:46]

lgtm with comment.

Thanks!

https://codereview.chromium.org/1245233002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
(right):

https://codereview.chromium.org/1245233002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java:192:
return url.substring(0, 1);
you could just return "url" here

[Theresa, 2015-07-21 18:18:02]

https://codereview.chromium.org/1245233002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
(right):

https://codereview.chromium.org/1245233002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java:192:
return url.substring(0, 1);
On 2015/07/21 17:53:45, newt wrote:
> you could just return "url" here

Done.

[Theresa, 2015-07-21 18:18:09]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2015-07-21 18:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1245233002/#ps40001
(title: "Return url as fallback")

[commit-bot: I haz the power, 2015-07-21 18:19:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245233002/40001

[commit-bot: I haz the power, 2015-07-21 19:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 19:59:48]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Theresa, 2015-07-21 21:29:40]

ptal @ RoundedIconGeneratorTest.java changes

[newt (away), 2015-07-21 22:12:34]

lgtm

[Theresa, 2015-07-21 22:29:42]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2015-07-21 22:31:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245233002/60001

[commit-bot: I haz the power, 2015-07-21 22:37:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-21 22:39:57]

Patchset 4 (id:??) landed as
https://crrev.com/242275ead23a63870c066023144c58762d882427
Cr-Commit-Position: refs/heads/master@{#339769}