chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java - Issue 1245233002: Add logic to parse "data:" URLs to RoundedIconGenerator.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

Issue 1245233002: Add logic to parse "data:" URLs to RoundedIconGenerator.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

index 868763c0a4b951184ada7911763a88e4daf3f417..adc6b7f116e3e9b33c1bd98d7a459372693bd333 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java

@@ -187,6 +187,6 @@ public class RoundedIconGenerator {

Log.w(TAG, "Unable to parse the URL for generating an icon: " + url);

}

- return null;

+ return url;

}

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java » ('j') | no next file with comments »