Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java

Issue 1245233002: Add logic to parse "data:" URLs to RoundedIconGenerator.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java
index 3a393f43142008f1b3c0aa0011624f4790bb8380..9ac2caee8d5eb45a9ec9ff3083864b4c1411ca4c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java
@@ -49,7 +49,9 @@ public class RoundedIconGeneratorTest extends NativeLibraryTestBase {
assertEquals("google-chrome", getIconTextForUrl("https://google-chrome/", false));
assertEquals("127.0.0.1", getIconTextForUrl("http://127.0.0.1/", false));
- // Verify that file:// URLs will still return NULL.
- assertNull(getIconTextForUrl("file:///home/chrome/test.html", false));
+ // Verify that the fallback is the the URL itself.
+ assertEquals("file:///home/chrome/test.html",
+ getIconTextForUrl("file:///home/chrome/test.html", false));
+ assertEquals("data:image", getIconTextForUrl("data:image", false));
}
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698