Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1244833002: make stroketext textblob* texteffects tileimagefilter gm portable (Closed)

Created:
5 years, 5 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make stroketext textblob* texteffects tileimagefilter gm portable TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/85693c15c8948911afb0036a1a01bda64157a0ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M gm/stroketext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobcolortrans.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M gm/textblobgeometrychange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobtransforms.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/textblobuseaftergpufree.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/texteffects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244833002/1
5 years, 5 months ago (2015-07-20 17:28:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/85693c15c8948911afb0036a1a01bda64157a0ab
5 years, 5 months ago (2015-07-20 17:48:03 UTC) #3
hal.canary
Can we #define SK_ColorDKGRAY 0xFF424242 #define SK_ColorGRAY 0xFF8C8C8C #define SK_ColorLTGRAY 0xFFCECECE ?
5 years, 5 months ago (2015-07-20 18:47:01 UTC) #5
hal.canary
On 2015/07/20 18:47:01, Hal Canary wrote: > Can we > > #define SK_ColorDKGRAY 0xFF424242 > ...
5 years, 5 months ago (2015-07-20 18:48:04 UTC) #6
caryclark
5 years, 5 months ago (2015-07-20 19:16:18 UTC) #7
Message was sent while issue was closed. 
On 2015/07/20 18:48:04, Hal Canary wrote:
> On 2015/07/20 18:47:01, Hal Canary wrote:
> > Can we
> > 
> >     #define SK_ColorDKGRAY 0xFF424242
> >     #define SK_ColorGRAY   0xFF8C8C8C
> >     #define SK_ColorLTGRAY 0xFFCECECE
> > 
> > ?
> 
> I mean
> 
>     #define SK_ColorDKGRAY 0xFF424542
>     #define SK_ColorGRAY   0xFF8C8A8C
>     #define SK_ColorLTGRAY 0xFFCECFCE

I think this is a good idea. However, implementing
it would require rebaselining all GM tests that use
these defines at once.

I prefer to rebaseline in smaller clumps. For portable
fonts, my plan is to change 

   set_portable_typeface(

to

   set_portable_typeface_always(

test by test, then once all tests have been rebaselined,
rename them all back to the simpler version. Gray colors
could be handled similarly.

Powered by Google App Engine
This is Rietveld 408576698