Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: Source/core/html/HTMLCanvasElement.idl

Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLCanvasElement.idl
diff --git a/Source/core/html/HTMLCanvasElement.idl b/Source/core/html/HTMLCanvasElement.idl
index b6d326c40df78aff6e2585d905f6867b69643a5c..a16f591356d480ba887e0f8606cf9ecd45340eac 100644
--- a/Source/core/html/HTMLCanvasElement.idl
+++ b/Source/core/html/HTMLCanvasElement.idl
@@ -49,6 +49,5 @@ interface HTMLCanvasElement : HTMLElement {
// Note: The arguments argument is variadic in the spec, but not here as
// only one extra argument is actually used.
- // FIXME: type should not be nullable or have a default value.
philipj_slow 2015/07/23 08:02:12 It still has a default value null, so leave that p
shiva.jm 2015/07/23 08:33:40 Done.
- [RaisesException] DOMString toDataURL(optional DOMString? type = null, optional any arguments);
+ [RaisesException] DOMString toDataURL(optional DOMString type = null, optional any arguments);
};

Powered by Google App Engine
This is Rietveld 408576698