Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: Source/core/html/HTMLCanvasElement.idl

Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 3 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // 42 //
43 // Also note: the only reason this must return type "any" is to allow the 43 // Also note: the only reason this must return type "any" is to allow the
44 // InspectorInstrumentation wrappers to be called for canvases. If that coul d be 44 // InspectorInstrumentation wrappers to be called for canvases. If that coul d be
45 // handled differently the return type could be changed to "RenderingContext ?" 45 // handled differently the return type could be changed to "RenderingContext ?"
46 // and the [CallWith=ScriptState] extended attribute removed. 46 // and the [CallWith=ScriptState] extended attribute removed.
47 // 47 //
48 [CallWith=ScriptState] any getContext(DOMString contextId, [PermissiveDictio naryConversion] optional CanvasContextCreationAttributes attributes); 48 [CallWith=ScriptState] any getContext(DOMString contextId, [PermissiveDictio naryConversion] optional CanvasContextCreationAttributes attributes);
49 49
50 // Note: The arguments argument is variadic in the spec, but not here as 50 // Note: The arguments argument is variadic in the spec, but not here as
51 // only one extra argument is actually used. 51 // only one extra argument is actually used.
52 // FIXME: type should not be nullable or have a default value. 52 [RaisesException] DOMString toDataURL(optional DOMString type = null, option al any arguments);
philipj_slow 2015/07/23 08:02:12 It still has a default value null, so leave that p
shiva.jm 2015/07/23 08:33:40 Done.
53 [RaisesException] DOMString toDataURL(optional DOMString? type = null, optio nal any arguments);
54 }; 53 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698