LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js - Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | Source/core/html/HTMLCanvasElement.idl » ('j') | Source/core/html/HTMLCanvasElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

index 3d125ade216823ae6125efdc6a024eec63c61523..716887044ea41780edcdb7e6108f6617087f9095 100644

--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

@@ -262,6 +262,7 @@ shouldBe("nonNumericPolicy('document.createElement(\"textarea\").setSelectionRan

// HTMLCanvasElement

+shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", "'any type allowed'");

philipj_slow 2015/07/23 08:02:12 Would this have failed before your change? I don't

shiva.jm 2015/07/23 08:33:40 Done.

shouldBe("nonNumericPolicy('createCanvasElement().getContext(x)')", "'any type allowed (but not omitted)'");

// KeyboardEvent