Issue 1244023004: Merge to XFA: document.delay and document.external are boolean properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1244023004: Merge to XFA: document.delay and document.external are boolean properties. (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: document.delay and document.external are boolean properties. (cherry picked from commit aafeff816e22c1333c17d8a0eb4fe8927c28142d) Original Review URL: https://codereview.chromium.org/1242263010 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f9fe200ca199287eb3331f32990f8c5b0cd040af

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -14 lines)			Patch
M	fpdfsdk/include/javascript/Document.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	1	2 chunks	+4 lines, -9 lines	0 comments	Download
M	testing/resources/javascript/document_props_expected.txt	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 5 months ago (2015-07-24 16:55:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f9fe200ca199287eb3331f32990f8c5b0cd040af (presubmit successful).