Merge to XFA: document.delay and document.external are boolean properties.

fpdfsdk/src/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 925 matching lines @@
 }
 
 FX_BOOL Document::delay(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         if (vp.IsGetting())
         {
                 vp << m_bDelay;
         }
         else
         {
-                ASSERT(m_pDocument != NULL);
+                if (!m_pDocument->GetPermissions(FPDFPERM_MODIFY))
+j                       return FALSE;
 
-                if (!m_pDocument->GetPermissions(FPDFPERM_MODIFY)) return FALSE;
-
-                bool b;
-                vp >> b;
-
-                m_bDelay = b;
-
+                vp >> m_bDelay;
                 if (m_bDelay)
                 {
                         for (int i=0,sz=m_DelayData.GetSize(); i<sz; i++)
                                 delete m_DelayData.GetAt(i);
 
                         m_DelayData.RemoveAll();
                 }
                 else
                 {
                         for (int i=0,sz=m_DelayData.GetSize(); i<sz; i++)
@@ skipping 137 matching lines @@
         return FALSE;
     }
     vp << m_pDocument->GetPageCount();
     return TRUE;
 }
 
 FX_BOOL Document::external(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
     //In Chrome case,should always return true.
     if (vp.IsGetting()) {
-        vp << TRUE;
+        vp << true;
     }
     return TRUE;
 }
 
 FX_BOOL Document::filesize(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
     if (vp.IsSetting()) {
         CJS_Context* pContext = static_cast<CJS_Context*>(cc);
         sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
         return FALSE;
@@ skipping 799 matching lines @@
     for (int j=DelArray.GetSize()-1; j>=0; j--)
     {
         m_DelayData.RemoveAt(DelArray[j]);
     }
 }
 
 CJS_Document* Document::GetCJSDoc() const
 {
     return static_cast<CJS_Document*>(m_pJSObject);
 }