Issue 1242263010: document.delay and document.external are boolean properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1242263010: document.delay and document.external are boolean properties. (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

document.delay and document.external are boolean properties. This is the javascript test failure at 320b2313d198. The spec says they are booleans, not ints, so correct the behaviour now. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aafeff816e22c1333c17d8a0eb4fe8927c28142d

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	fpdfsdk/include/javascript/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	testing/resources/javascript/document_props_expected.txt	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, fix this bug independently of other bool work. Thanks,

5 years, 5 months ago (2015-07-23 22:59:48 UTC) #2

Lei Zhang

lgtm, per http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf pages 237 and 240.

5 years, 5 months ago (2015-07-23 23:03:50 UTC) #3

Tom Sepez

5 years, 5 months ago (2015-07-23 23:08:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aafeff816e22c1333c17d8a0eb4fe8927c28142d (presubmit successful).