Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1243383002: Add skia_use_android_framework_defines GYP_DEFINE (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add skia_use_android_framework_defines GYP_DEFINE BUG=skia:4082 Committed: https://skia.googlesource.com/skia/+/243406e5800ad4ff296da8d4cb30d0a33d6f7b2a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M gyp/common_conditions.gypi View 1 2 chunks +12 lines, -4 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
borenet
5 years, 5 months ago (2015-07-22 12:43:47 UTC) #2
scroggo
lgtm, thanks! https://codereview.chromium.org/1243383002/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/1243383002/diff/1/gyp/common_conditions.gypi#newcode400 gyp/common_conditions.gypi:400: '<@(skia_for_android_framework_defines)', Should we instead set skia_use_android_framework_defines to ...
5 years, 5 months ago (2015-07-22 13:02:43 UTC) #3
borenet
https://codereview.chromium.org/1243383002/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/1243383002/diff/1/gyp/common_conditions.gypi#newcode400 gyp/common_conditions.gypi:400: '<@(skia_for_android_framework_defines)', On 2015/07/22 13:02:43, scroggo wrote: > Should we ...
5 years, 5 months ago (2015-07-22 13:32:35 UTC) #4
scroggo
LGTM, although I might hesitate to commit until the merge bot is fixed. (Matt is ...
5 years, 5 months ago (2015-07-22 13:39:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243383002/20001
5 years, 5 months ago (2015-07-22 18:57:28 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 20:29:28 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/243406e5800ad4ff296da8d4cb30d0a33d6f7b2a

Powered by Google App Engine
This is Rietveld 408576698