Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: gyp/common_conditions.gypi

Issue 1243383002: Add skia_use_android_framework_defines GYP_DEFINE (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 Google Inc. 1 # Copyright 2015 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # conditions used in both common.gypi and skia.gyp in chromium 6 # conditions used in both common.gypi and skia.gyp in chromium
7 # 7 #
8 { 8 {
9 'defines': [ 9 'defines': [
10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 }], 324 }],
325 ], 325 ],
326 }], 326 }],
327 ], 327 ],
328 }], 328 }],
329 ], 329 ],
330 }, 330 },
331 ], 331 ],
332 332
333 ['skia_android_framework', { 333 ['skia_android_framework', {
334 'includes' : [
335 'skia_for_android_framework_defines.gypi',
336 ],
337 'cflags': [ 334 'cflags': [
338 # Skia does not enforce this usage pattern so we disable it here to avoi d 335 # Skia does not enforce this usage pattern so we disable it here to avoi d
339 # unecessary log spew when building 336 # unecessary log spew when building
340 '-Wno-unused-parameter', 337 '-Wno-unused-parameter',
341 338
342 # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkStri ng. 339 # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkStri ng.
343 # Revert to -D_FORTIFY_SOURCE=1 340 # Revert to -D_FORTIFY_SOURCE=1
344 '-U_FORTIFY_SOURCE', 341 '-U_FORTIFY_SOURCE',
345 '-D_FORTIFY_SOURCE=1', 342 '-D_FORTIFY_SOURCE=1',
346 343
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 # Optimizations for chromium (m30) 386 # Optimizations for chromium (m30)
390 'GR_GL_CUSTOM_SETUP_HEADER "gl/GrGLConfig_chrome.h"', 387 'GR_GL_CUSTOM_SETUP_HEADER "gl/GrGLConfig_chrome.h"',
391 'IGNORE_ROT_AA_RECT_OPT', 388 'IGNORE_ROT_AA_RECT_OPT',
392 'SK_DEFAULT_FONT_CACHE_LIMIT (768 * 1024)', 389 'SK_DEFAULT_FONT_CACHE_LIMIT (768 * 1024)',
393 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)', 390 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)',
394 'SK_IGNORE_ETC1_SUPPORT', 391 'SK_IGNORE_ETC1_SUPPORT',
395 # We can't use the skia_shared_library gyp setting because we need expos e 392 # We can't use the skia_shared_library gyp setting because we need expos e
396 # this define globally and the the implemention define as a cflag. 393 # this define globally and the the implemention define as a cflag.
397 'SKIA_DLL', 394 'SKIA_DLL',
398 'SK_PRINT_CODEC_MESSAGES', 395 'SK_PRINT_CODEC_MESSAGES',
399 # Defines from skia_for_android_framework_defines.gypi 396 ],
397 }],
398
399 ['skia_use_android_framework_defines', {
400 # Add these defines when building for the Android framework, or when
401 # specifically requested. These should be temporary staging defines. Any
402 # permanent defines should be moved into the skia_android_framework block
403 # above.
404 'includes' : [
405 'skia_for_android_framework_defines.gypi',
406 ],
407 'defines': [
400 '<@(skia_for_android_framework_defines)', 408 '<@(skia_for_android_framework_defines)',
401 ], 409 ],
402 }], 410 }],
403 411
404 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "chromeos"]', 412 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "chromeos"]',
405 { 413 {
406 'defines': [ 414 'defines': [
407 'SK_SAMPLES_FOR_X', 415 'SK_SAMPLES_FOR_X',
408 'SK_BUILD_FOR_UNIX', 416 'SK_BUILD_FOR_UNIX',
409 ], 417 ],
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 [ 'sknx_no_simd', { 640 [ 'sknx_no_simd', {
633 'defines': [ 'SKNX_NO_SIMD' ], 641 'defines': [ 'SKNX_NO_SIMD' ],
634 }], 642 }],
635 643
636 ], # end 'conditions' 644 ], # end 'conditions'
637 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details 645 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
638 'xcode_settings': { 646 'xcode_settings': {
639 'SYMROOT': '<(DEPTH)/xcodebuild', 647 'SYMROOT': '<(DEPTH)/xcodebuild',
640 }, 648 },
641 } 649 }
OLDNEW
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698