Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: gyp/common_conditions.gypi

Issue 1243383002: Add skia_use_android_framework_defines GYP_DEFINE (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index ba4337403d99621a1c1ed291715a1c919cd459b5..2c88a973f9c738f42eb32e54e074e5c1ef13b822 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -331,9 +331,6 @@
],
['skia_android_framework', {
- 'includes' : [
- 'skia_for_android_framework_defines.gypi',
- ],
'cflags': [
# Skia does not enforce this usage pattern so we disable it here to avoid
# unecessary log spew when building
@@ -396,7 +393,18 @@
# this define globally and the the implemention define as a cflag.
'SKIA_DLL',
'SK_PRINT_CODEC_MESSAGES',
- # Defines from skia_for_android_framework_defines.gypi
+ ],
+ }],
+
+ ['skia_use_android_framework_defines', {
+ # Add these defines when building for the Android framework, or when
+ # specifically requested. These should be temporary staging defines. Any
+ # permanent defines should be moved into the skia_android_framework block
+ # above.
+ 'includes' : [
+ 'skia_for_android_framework_defines.gypi',
+ ],
+ 'defines': [
'<@(skia_for_android_framework_defines)',
],
}],
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698