App Info: `View in Webstore` closes before navigating (not after)

App Info: `View in Webstore` closes the dialog before navigating (not after)

Currently, when clicking the 'View in Webstore' link in the App Info
dialog, a new tab is created first then the dialog is closed. This isn't
a problem on most platforms because the dialog is still window-modal, so
it fades out regardless of which tab is focused.

However, On Mac (and eventually perhaps elsewhere) the dialog is tab-
modal. This means that opening a new tab for the navigation will first
hide the dialog. Then, the fade-out occurs, which will show it again.

A simple fix is to swap the lines to Close() the dialog and the
navigation. This starts the dialog fading out before the tab switch
hides it to show the webstore. Close() is asynchronous, so this is fine,
but it looks a bit scary. AppInfo could do with more test coverage
anyway, so add a test.

Use BrowserWithTestWindowTest to avoid creating a browser_test. It needs
a bit of a spruce-up to work on Mac, and can benefit from more code
reuse by using ScopedViewsTestHelper.

Tweaks TestExtensionEnvironment so it plays nice with a wider range of
test harnesses, and adds the FROM_WEBSTORE manifest property by
default (otherwise AppInfo omits the `Show in Webstore` link).

BUG=485854
Committed: https://crrev.com/dfd8edaae421cf5533c2033acde474498c2ee469
Cr-Commit-Position: refs/heads/master@{#341702}

[tapted, 2015-07-23 06:54:06]

Patchset #3 (id:40001) has been deleted

[tapted, 2015-07-23 07:09:16]

tapted@chromium.org changed reviewers:
+ jackhou@chromium.org

[tapted, 2015-07-23 07:09:34]

Patchset #3 (id:60001) has been deleted

[tapted, 2015-07-24 06:10:46]

Hi Jack, could you please do a local review - Thanks!

[jackhou1, 2015-07-27 01:31:26]

lgtm

We probably want to do the same with links in app_info_summary_panel.cc.

[tapted, 2015-07-30 00:28:13]

tapted@chromium.org changed reviewers:
+ benwells@chromium.org, sky@chromium.org

[tapted, 2015-07-30 00:28:14]

+sky for chrome/test/base OWNERS
+benwells for chrome/browser/extensions OWNERS

please take a look.

[sky, 2015-08-03 16:32:01]

LGTM

[benwells, 2015-08-04 06:12:23]

lgtm

[tapted, 2015-08-04 07:12:56]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2015-08-04 07:13:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243033003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1243033003/140001

[commit-bot: I haz the power, 2015-08-04 08:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 08:31:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tapted, 2015-08-04 08:32:03]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2015-08-04 08:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243033003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1243033003/140001

[commit-bot: I haz the power, 2015-08-04 09:15:31]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-08-04 09:17:15]

Patchset 6 (id:??) landed as
https://crrev.com/dfd8edaae421cf5533c2033acde474498c2ee469
Cr-Commit-Position: refs/heads/master@{#341702}