App Info: `View in Webstore` closes before navigating (not after)

chrome/browser/extensions/test_extension_environment.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/test_extension_environment.h"
 
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/run_loop.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "content/public/test/web_contents_tester.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
+#include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/chromeos/settings/device_settings_service.h"
+#endif
+
 #if defined(USE_AURA)
 #include "ui/aura/env.h"
 #endif
 
 namespace extensions {
 
 using content::BrowserThread;
 
 namespace {
 
@@ skipping 23 matching lines @@
       .Set("app", extensions::DictionaryBuilder().Set(
                       "background",
                       extensions::DictionaryBuilder().Set(
                           "scripts",
                           extensions::ListBuilder().Append("background.js"))))
       .Build();
 }
 
 }  // namespace
 
+// Extra environment state required for ChromeOS.
+class TestExtensionEnvironment::ChromeOSEnv {
+ public:
+  ChromeOSEnv() {}
+
+ private:
+#if defined(OS_CHROMEOS)
+  chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
+  chromeos::ScopedTestCrosSettings test_cros_settings_;
+  chromeos::ScopedTestUserManager test_user_manager_;
+#endif
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeOSEnv);
+};
+
 // static
 ExtensionService* TestExtensionEnvironment::CreateExtensionServiceForProfile(
     TestingProfile* profile) {
   TestExtensionSystem* extension_system =
       static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile));
   return extension_system->CreateExtensionService(
       base::CommandLine::ForCurrentProcess(), base::FilePath(), false);
 }
 
 TestExtensionEnvironment::TestExtensionEnvironment()
     : thread_bundle_(new content::TestBrowserThreadBundle),
-      profile_(new TestingProfile),
       extension_service_(nullptr) {
-#if defined(USE_AURA)
-  aura::Env::CreateInstance(true);
-#endif
+  Init();
 }
 
 TestExtensionEnvironment::TestExtensionEnvironment(
     base::MessageLoopForUI* message_loop)
-    : profile_(new TestingProfile), extension_service_(nullptr) {
+    : extension_service_(nullptr) {
+  Init();
+}
+
+void TestExtensionEnvironment::Init() {
+  profile_.reset(new TestingProfile);
+#if defined(OS_CHROMEOS)
+  if (!chromeos::DeviceSettingsService::IsInitialized())
+    chromeos_env_.reset(new ChromeOSEnv);
+#endif
 #if defined(USE_AURA)
   aura::Env::CreateInstance(true);
 #endif
 }
 
 TestExtensionEnvironment::~TestExtensionEnvironment() {
 #if defined(USE_AURA)
   aura::Env::DeleteInstance();
 #endif
 }
@@ skipping 35 matching lines @@
       ExtensionBuilder().SetManifest(manifest.Pass()).SetID(id).Build();
   GetExtensionService()->AddExtension(result.get());
   return result.get();
 }
 
 scoped_refptr<Extension> TestExtensionEnvironment::MakePackagedApp(
     const std::string& id,
     bool install) {
   scoped_refptr<Extension> result = ExtensionBuilder()
                                         .SetManifest(MakePackagedAppManifest())
+                                        .AddFlags(Extension::FROM_WEBSTORE)
                                         .SetID(id)
                                         .Build();
   if (install)
     GetExtensionService()->AddExtension(result.get());
   return result;
 }
 
 scoped_ptr<content::WebContents> TestExtensionEnvironment::MakeTab() const {
   scoped_ptr<content::WebContents> contents(
       content::WebContentsTester::CreateTestWebContents(profile(), NULL));
   // Create a tab id.
   SessionTabHelper::CreateForWebContents(contents.get());
   return contents.Pass();
 }
 
 void TestExtensionEnvironment::DeleteProfile() {
   profile_.reset();
   extension_service_ = nullptr;
 }
 
 }  // namespace extensions