chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc - Issue 1243033003: App Info: `View in Webstore` closes before navigating (not after)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc

Issue 1243033003: App Info: `View in Webstore` closes before navigating (not after) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Likely fix for CrOS Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h ('k') | chrome/test/base/browser_with_test_window_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc

index 6db2dff52c5b98951fff91b4b238916bc330f84e..a14bb9de90653d0699308e9493c158915a4b4d10 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc

@@ -131,11 +131,11 @@ void AppInfoHeaderPanel::OnAppImageLoaded(const gfx::Image& image) {

void AppInfoHeaderPanel::ShowAppInWebStore() {

DCHECK(CanShowAppInWebStore());

+ Close();

OpenLink(net::AppendQueryParameter(

extensions::ManifestURL::GetDetailsURL(app_),

extension_urls::kWebstoreSourceField,

extension_urls::kLaunchSourceAppListInfoDialog));

- Close();

}

bool AppInfoHeaderPanel::CanShowAppInWebStore() const {