Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1242913003: Temporarily crash the GPU process when unexpected failures happen. (Closed)

Created:
5 years, 5 months ago by David Yen
Modified:
5 years, 5 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily crash the GPU process when unexpected failures happen. There is an ongoing issue with failures on Mac OSX causing crashes on the renderer side. All we know so far is that it has something to do with failures with our usage of GL_COMMANDS_COMPLETED_CHROMIUM. We suspect it has something to do with multiple GPUs but it is hard to tell for sure. This will at least let us know what is going on for the GPU side. BUG=467678 Committed: https://crrev.com/27cfeeeaa3faee230d2d526b13a3b0dee056022e Cr-Commit-Position: refs/heads/master@{#339703}

Patch Set 1 #

Patch Set 2 : Added todo comments #

Patch Set 3 : Added a different crash line for each fence support combination" #

Patch Set 4 : Added gfx namespace #

Patch Set 5 : Removed unit test temporarily for mac #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 chunks +37 lines, -0 lines 1 comment Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
David Yen
5 years, 5 months ago (2015-07-20 22:53:49 UTC) #2
David Yen
I am adding these crashes so we can know what is causing the GPU to ...
5 years, 5 months ago (2015-07-20 23:00:32 UTC) #3
Zhenyao Mo
On 2015/07/20 22:53:49, David Yen wrote: LGTM
5 years, 5 months ago (2015-07-20 23:01:56 UTC) #4
Zhenyao Mo
On 2015/07/20 23:01:56, Zhenyao Mo wrote: > On 2015/07/20 22:53:49, David Yen wrote: > > ...
5 years, 5 months ago (2015-07-20 23:21:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242913003/60001
5 years, 5 months ago (2015-07-20 23:24:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/89352)
5 years, 5 months ago (2015-07-21 00:50:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242913003/80001
5 years, 5 months ago (2015-07-21 16:33:41 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-21 18:28:17 UTC) #13
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/27cfeeeaa3faee230d2d526b13a3b0dee056022e Cr-Commit-Position: refs/heads/master@{#339703}
5 years, 5 months ago (2015-07-21 18:29:21 UTC) #14
piman
5 years, 5 months ago (2015-07-21 19:17:06 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/1242913003/diff/80001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1242913003/diff/80001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11626: CHECK(false) << "Unknown
error.";
drive-by FYI: you can use base::debug::Alias to make sure a particular stack
variable is not optimized, so you can observe it from the crash dump.

Powered by Google App Engine
This is Rietveld 408576698