Temporarily crash the GPU process when unexpected failures happen.

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stdio.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 11587 matching lines @@
 
   switch (target) {
     case GL_COMMANDS_ISSUED_CHROMIUM:
     case GL_LATENCY_QUERY_CHROMIUM:
     case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM:
     case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM:
     case GL_GET_ERROR_QUERY_CHROMIUM:
       break;
     case GL_COMMANDS_COMPLETED_CHROMIUM:
       if (!features().chromium_sync_query) {
+#if defined(OS_MACOSX)
+        // TODO(dyen): Remove once we know what is failing.
+        uint32_t boolean_flags = 0;
+        if (gfx::g_driver_gl.ext.b_GL_ARB_sync)
+          boolean_flags |= 1;
+        if (gfx::g_driver_gl.ext.b_GL_APPLE_fence)
+          boolean_flags |= 2;
+        if (gfx::g_driver_gl.ext.b_GL_NV_fence)
+          boolean_flags |= 4;
+
+        CHECK(boolean_flags != 0) << "Nothing supported";
+        CHECK(boolean_flags != 1) << "ARB";
+        CHECK(boolean_flags != 2) << "APPLE";
+        CHECK(boolean_flags != 3) << "ARB APPLE";
+        CHECK(boolean_flags != 4) << "NV";
+        CHECK(boolean_flags != 5) << "NV ARB";
+        CHECK(boolean_flags != 6) << "NV APPLE";
+        CHECK(boolean_flags != 7) << "NV ARB APPLE";
+        CHECK(false) << "Unknown error.";

[piman, 2015/07/21 19:17:05]

drive-by FYI: you can use base::debug::Alias to make sure a particular stack
variable is not optimized, so you can observe it from the crash dump.

+#endif
         LOCAL_SET_GL_ERROR(
             GL_INVALID_OPERATION, "glBeginQueryEXT",
             "not enabled for commands completed queries");
         return error::kNoError;
       }
       break;
     case GL_SAMPLES_PASSED:
     case GL_ANY_SAMPLES_PASSED:
     case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
       if (!features().occlusion_query_boolean) {
@@ skipping 12 matching lines @@
       }
       break;
     default:
       LOCAL_SET_GL_ERROR(
           GL_INVALID_ENUM, "glBeginQueryEXT",
           "unknown query target");
       return error::kNoError;
   }
 
   if (state_.current_queries.find(target) != state_.current_queries.end()) {
+#if defined(OS_MACOSX)
+    // TODO(dyen): Remove once we know what is failing.
+    CHECK(target != GL_COMMANDS_COMPLETED_CHROMIUM)
+        << "Query already in progress";
+#endif
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION, "glBeginQueryEXT", "query already in progress");
     return error::kNoError;
   }
 
   if (client_id == 0) {
+#if defined(OS_MACOSX)
+    // TODO(dyen): Remove once we know what is failing.
+    CHECK(target != GL_COMMANDS_COMPLETED_CHROMIUM) << "Id is 0";
+#endif
     LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glBeginQueryEXT", "id is 0");
     return error::kNoError;
   }
 
   QueryManager::Query* query = query_manager_->GetQuery(client_id);
   if (!query) {
     if (!query_manager_->IsValidQuery(client_id)) {
+#if defined(OS_MACOSX)
+      // TODO(dyen): Remove once we know what is failing.
+      CHECK(target != GL_COMMANDS_COMPLETED_CHROMIUM) << "Invalid ID";
+#endif
       LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION,
                          "glBeginQueryEXT",
                          "id not made by glGenQueriesEXT");
       return error::kNoError;
     }
     query = query_manager_->CreateQuery(
         target, client_id, sync_shm_id, sync_shm_offset);
   }
 
   if (query->target() != target) {
+#if defined(OS_MACOSX)
+    // TODO(dyen): Remove once we know what is failing.
+    CHECK(target != GL_COMMANDS_COMPLETED_CHROMIUM) << "Non-Matching Target";
+#endif
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION, "glBeginQueryEXT", "target does not match");
     return error::kNoError;
   } else if (query->shm_id() != sync_shm_id ||
              query->shm_offset() != sync_shm_offset) {
     DLOG(ERROR) << "Shared memory used by query not the same as before";
     return error::kInvalidArguments;
   }
 
   if (!query_manager_->BeginQuery(query)) {
@@ skipping 2711 matching lines @@
   return error::kNoError;
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu