Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Issue 1242913003: Temporarily crash the GPU process when unexpected failures happen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unit test temporarily for mac Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
index ae525d457c924428fe48c9dd3891b4a22f737cb0..162eb6a7ffbe612bf6d023235c5f81a84952041e 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
@@ -992,12 +992,15 @@ TEST_P(GLES2DecoderManualInitTest, BeginInvalidTargetQueryFails) {
GenHelper<GenQueriesEXTImmediate>(kNewClientId);
BeginQueryEXT begin_cmd;
+#if !defined(OS_MACOSX)
+ // TODO(dyen): Remove once we know what is failing.
begin_cmd.Init(GL_COMMANDS_COMPLETED_CHROMIUM,
kNewClientId,
kSharedMemoryId,
kSharedMemoryOffset);
EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));
EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
+#endif // !defined(OS_MACOSX)
begin_cmd.Init(GL_ANY_SAMPLES_PASSED,
kNewClientId,

Powered by Google App Engine
This is Rietveld 408576698