Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1242333005: Partial revert of Enable MSVC warning C4018 for various directories that seem to pass as-is. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
brettw, Peter Kasting
CC:
cbentzel+watch_chromium.org, chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of Enable MSVC warning C4018 for various directories that seem to pass as-is. (patchset #2 id:20001 of https://codereview.chromium.org/1246863002/) Reason for revert: Got a signed/unsigned mismatch warning on GPU Win Builder (gtffixedtestvertexorder.c:58). Reverting change to gles2_conform_test.gyp; other files not reverted. Original issue's description: > Enable MSVC warning C4018 for various directories that seem to pass as-is. > > BUG=398202 > TEST=none > TBR=brettw > > Committed: https://crrev.com/513df87e8724587dc7be0d27a5f79652275c0767 > Cr-Commit-Position: refs/heads/master@{#339602} TBR=brettw@chromium.org,pkasting@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398202 Committed: https://crrev.com/2e73278918aeab1d0f4d028e48d8ba85a1b0c8c1 Cr-Commit-Position: refs/heads/master@{#339606}

Patch Set 1 #

Patch Set 2 : Just revert gles2_conform_test.gyp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/gles2_conform_support/gles2_conform_test.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Matt Giuca
Created Revert of Enable MSVC warning C4018 for various directories that seem to pass as-is.
5 years, 5 months ago (2015-07-21 03:13:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242333005/1
5 years, 5 months ago (2015-07-21 03:13:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242333005/120001
5 years, 5 months ago (2015-07-21 03:19:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 5 months ago (2015-07-21 03:20:00 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 03:20:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e73278918aeab1d0f4d028e48d8ba85a1b0c8c1
Cr-Commit-Position: refs/heads/master@{#339606}

Powered by Google App Engine
This is Rietveld 408576698