Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: gpu/gles2_conform_support/gles2_conform_test.gyp

Issue 1242333005: Partial revert of Enable MSVC warning C4018 for various directories that seem to pass as-is. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just revert gles2_conform_test.gyp. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/gles2_conform_support/gles2_conform_test.gyp
diff --git a/gpu/gles2_conform_support/gles2_conform_test.gyp b/gpu/gles2_conform_support/gles2_conform_test.gyp
index 2abe93f4f946ce807537a87a7ff79973968d43c0..1f23efa3c3cd0fc507cb27f9f972ad1225f02d40 100644
--- a/gpu/gles2_conform_support/gles2_conform_test.gyp
+++ b/gpu/gles2_conform_support/gles2_conform_test.gyp
@@ -8,7 +8,7 @@
'gles2_conform.gypi',
],
'target_defaults': {
- 'msvs_disabled_warnings': [4005, 4013, 4101, 4716],
+ 'msvs_disabled_warnings': [4005, 4013, 4018, 4101, 4716],
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)/gles2_conform_test_embedded_data',
'../../third_party/gles2_conform/GTF_ES/glsl/GTF/Source',
@@ -134,6 +134,7 @@
'EGLAPIENTRY=',
],
'msvs_disabled_warnings': [
+ 4018, # signed/unsigned mismatch
4101, # unreferenced local variable
4715, # not all control paths return a value
4267, # size_t/unsigned int conversion
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698