Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1242323004: Add missing dependencies. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
danakj, marcheu, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing runtime dependencies to *_run targets. A follow up CL removes dynamic libraries that would be fetched automatically via implicit dependencies. The target hierarchy needs to be there in the first place for this to work. R=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9 Cr-Commit-Position: refs/heads/master@{#339994}

Patch Set 1 #

Patch Set 2 : Fix many new tests #

Total comments: 3

Patch Set 3 : Update mesa dependency to be on the actual executable #

Patch Set 4 : Rebase against ToT, there was a small conflict #

Patch Set 5 : Added comment, migrated all osmesa dependencies #

Total comments: 2

Patch Set 6 : Remove unnecessary dependency #

Total comments: 1

Patch Set 7 : osmesa really need to be a dep of each exe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M cc/cc_tests.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 3 chunks +4 lines, -1 line 0 comments Download
M extensions/extensions_tests.gyp View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (5 generated)
M-A Ruel
This CL is a prerequisite to https://codereview.chromium.org/1242783002/. It permits being able to compile one unit ...
5 years, 5 months ago (2015-07-20 20:41:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242323004/20001
5 years, 5 months ago (2015-07-20 21:29:56 UTC) #3
jam
https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi#newcode2885 chrome/chrome_tests_unit.gypi:2885: '../third_party/mesa/mesa.gyp:osmesa', here and in other places, shouldn't this be ...
5 years, 5 months ago (2015-07-20 22:52:14 UTC) #4
M-A Ruel
So, should test_support depend on osmesa? https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi#newcode2885 chrome/chrome_tests_unit.gypi:2885: '../third_party/mesa/mesa.gyp:osmesa', On 2015/07/20 ...
5 years, 5 months ago (2015-07-20 23:18:46 UTC) #6
jam
On 2015/07/20 23:18:46, M-A Ruel wrote: > So, should test_support depend on osmesa? which code ...
5 years, 5 months ago (2015-07-20 23:29:33 UTC) #7
M-A Ruel
On 2015/07/20 23:29:33, jam wrote: > On 2015/07/20 23:18:46, M-A Ruel wrote: > > So, ...
5 years, 5 months ago (2015-07-20 23:48:40 UTC) #8
danakj
https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/1242323004/diff/20001/chrome/chrome_tests_unit.gypi#newcode2885 chrome/chrome_tests_unit.gypi:2885: '../third_party/mesa/mesa.gyp:osmesa', On 2015/07/20 23:18:46, M-A Ruel wrote: > On ...
5 years, 5 months ago (2015-07-20 23:56:43 UTC) #9
M-A Ruel
On 2015/07/20 23:56:43, danakj wrote: > it'd be nice if they are a dep of ...
5 years, 5 months ago (2015-07-20 23:59:20 UTC) #10
M-A Ruel
On 2015/07/20 23:59:20, M-A Ruel wrote: > On 2015/07/20 23:56:43, danakj wrote: > > it'd ...
5 years, 5 months ago (2015-07-21 12:44:55 UTC) #11
Dirk Pranke
On 2015/07/20 23:56:43, danakj wrote: > it'd be nice if they are a dep of ...
5 years, 5 months ago (2015-07-21 15:14:05 UTC) #12
jam
On 2015/07/21 15:14:05, Dirk Pranke wrote: > On 2015/07/20 23:56:43, danakj wrote: > > it'd ...
5 years, 5 months ago (2015-07-21 16:16:31 UTC) #13
danakj
On 2015/07/21 16:16:31, jam wrote: > On 2015/07/21 15:14:05, Dirk Pranke wrote: > > On ...
5 years, 5 months ago (2015-07-21 17:37:20 UTC) #14
M-A Ruel
On 2015/07/21 17:37:20, danakj wrote: > can you maybe also leave a comment on these ...
5 years, 5 months ago (2015-07-22 18:53:26 UTC) #15
danakj
https://codereview.chromium.org/1242323004/diff/80001/cc/cc_tests.gyp File cc/cc_tests.gyp (right): https://codereview.chromium.org/1242323004/diff/80001/cc/cc_tests.gyp#newcode298 cc/cc_tests.gyp:298: '../third_party/mesa/mesa.gyp:osmesa', How come you need this if the cc_test_support ...
5 years, 5 months ago (2015-07-22 19:01:48 UTC) #16
M-A Ruel
https://codereview.chromium.org/1242323004/diff/80001/cc/cc_tests.gyp File cc/cc_tests.gyp (right): https://codereview.chromium.org/1242323004/diff/80001/cc/cc_tests.gyp#newcode298 cc/cc_tests.gyp:298: '../third_party/mesa/mesa.gyp:osmesa', On 2015/07/22 19:01:48, danakj wrote: > How come ...
5 years, 5 months ago (2015-07-22 19:06:27 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242323004/100001
5 years, 5 months ago (2015-07-22 20:03:55 UTC) #19
danakj
https://codereview.chromium.org/1242323004/diff/100001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/1242323004/diff/100001/components/components_tests.gyp#newcode773 components/components_tests.gyp:773: '../content/content_shell_and_tests.gyp:test_support_content', This leads me to similar questions about the ...
5 years, 5 months ago (2015-07-22 20:09:46 UTC) #20
M-A Ruel
On 2015/07/22 20:09:46, danakj wrote: > https://codereview.chromium.org/1242323004/diff/100001/components/components_tests.gyp > File components/components_tests.gyp (right): > > https://codereview.chromium.org/1242323004/diff/100001/components/components_tests.gyp#newcode773 > ...
5 years, 5 months ago (2015-07-22 20:36:41 UTC) #21
M-A Ruel
On 2015/07/22 20:36:41, M-A Ruel wrote: > On 2015/07/22 20:09:46, danakj wrote: > > > ...
5 years, 5 months ago (2015-07-22 20:51:41 UTC) #22
danakj
OK LGTM
5 years, 5 months ago (2015-07-22 21:25:39 UTC) #23
danakj
On 2015/07/22 21:25:39, danakj wrote: > OK LGTM Hopefully GN can do better, cuz new ...
5 years, 5 months ago (2015-07-22 21:26:18 UTC) #24
M-A Ruel
On 2015/07/22 21:26:18, danakj wrote: > On 2015/07/22 21:25:39, danakj wrote: > > OK LGTM ...
5 years, 5 months ago (2015-07-22 21:46:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242323004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242323004/120001
5 years, 5 months ago (2015-07-22 21:48:12 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-23 00:13:19 UTC) #29
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9 Cr-Commit-Position: refs/heads/master@{#339994}
5 years, 5 months ago (2015-07-23 00:14:05 UTC) #30
Michael Courage
5 years, 5 months ago (2015-07-23 00:49:56 UTC) #31
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1247533003/ by courage@chromium.org.

The reason for reverting is: It looks to me like this broke the iOS_Device
builder starting at
https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/14003,
despite the green trybots. 

=== BUILD TARGET osmesa OF PROJECT mesa WITH CONFIGURATION Release ===

Check dependencies
CodeSign error: code signing is required for product type 'Dynamic Library' in
SDK 'iOS 8.3'

** BUILD FAILED **


The following build commands failed:
	Check dependencies
(1 failure)
.

Powered by Google App Engine
This is Rietveld 408576698