The index argument for HTMLCollection item() api should not be optional

The index argument for HTMLCollection item() api should not be optional

As per spec link:
https://dom.spec.whatwg.org/#interface-htmlcollection,
index argument for HTMLCollection item() api should
not be optional.

Firefox throws TypeError:Not enough arguments,
if argument is missing. But IE treats the argument as
optional, defaulting to 0.

BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199198

[shiva.jm, 2015-07-20 06:58:30]

shiva.jm@samsung.com changed reviewers:
+ philipj@opera.com, tkent@chromium.org

[shiva.jm, 2015-07-20 06:58:31]

pls have a look.

[philipj_slow, 2015-07-20 07:21:27]

On 2015/07/20 06:58:31, shiva.jm wrote:
> pls have a look.

For changes of this type, please also test IE behavior. The tools to do so can
be found at http://dev.modern.ie/tools/

I just tested, and IE treats the argument as optional, defaulting to 0. That
makes this slightly riskier, but given Gecko's behavior I think it's still worth
trying.

tkent@, WDYT?

[philipj_slow, 2015-07-20 07:21:33]

https://codereview.chromium.org/1242233002/diff/20001/LayoutTests/fast/dom/ht...
File LayoutTests/fast/dom/html-collections-named-getter-mandatory-arg.html
(right):

https://codereview.chromium.org/1242233002/diff/20001/LayoutTests/fast/dom/ht...
LayoutTests/fast/dom/html-collections-named-getter-mandatory-arg.html:15:
shouldThrow("htmlCollection.item()", '"TypeError: Failed to execute \'item\' on
\'HTMLCollection\': 1 argument required, but only 0 present."');
"This test verifies that HTMLCollection.namedItem() argument is mandatory"

Given that
LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt already
verifies the behavior, just revert the changes to this test.

[shiva.jm, 2015-07-20 08:41:37]

Patchset #3 (id:40001) has been deleted

[shiva.jm, 2015-07-20 09:55:54]

Updated tests and discription, pls have a look.

https://codereview.chromium.org/1242233002/diff/20001/LayoutTests/fast/dom/ht...
File LayoutTests/fast/dom/html-collections-named-getter-mandatory-arg.html
(right):

https://codereview.chromium.org/1242233002/diff/20001/LayoutTests/fast/dom/ht...
LayoutTests/fast/dom/html-collections-named-getter-mandatory-arg.html:15:
shouldThrow("htmlCollection.item()", '"TypeError: Failed to execute \'item\' on
\'HTMLCollection\': 1 argument required, but only 0 present."');
On 2015/07/20 07:21:33, philipj wrote:
> "This test verifies that HTMLCollection.namedItem() argument is mandatory"
> 
> Given that
> LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
already
> verifies the behavior, just revert the changes to this test.

Done.

[philipj_slow, 2015-07-20 10:38:38]

LGTM, but since it's optional in IE the risk is higher than some of these
changes, so I'd like to hear what tkent@ thinks too.

[shiva.jm, 2015-07-20 10:47:06]

The CQ bit was checked by shiva.jm@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 10:47:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242233002/60001

[shiva.jm, 2015-07-20 10:47:34]

The CQ bit was unchecked by shiva.jm@samsung.com

[tkent, 2015-07-21 00:30:56]

On 2015/07/20 07:21:27, philipj wrote:
> I just tested, and IE treats the argument as optional, defaulting to 0. That
> makes this slightly riskier, but given Gecko's behavior I think it's still
worth
> trying.
> 
> tkent@, WDYT?

Let's go ahead.

[shiva.jm, 2015-07-21 03:33:14]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-07-21 03:33:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242233002/60001

[commit-bot: I haz the power, 2015-07-21 04:01:53]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199198