LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js - Issue 1242233002: The index argument for HTMLCollection item() api should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 1242233002: The index argument for HTMLCollection item() api should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | Source/core/html/HTMLCollection.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

diff --git a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

index f7ddfdc7e3f2803108577a4529960f219ed98fc5..5eb07bdf4325fb22ffcb8deaf9b32396ced360dc 100644

--- a/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

+++ b/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

@@ -218,7 +218,7 @@ shouldBe("nonNumericPolicy('document.body.scrollTop = x')", "'any type allowed'"

// HTMLCollection

-shouldBe("nonNumericPolicy('document.images.item(x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('document.images.item(x)')", "'any type allowed (but not omitted)'");

// HTMLInputElement

@@ -282,7 +282,7 @@ shouldBe("nonNumericPolicy('document.createNodeIterator(document, x, null, false

// NodeList

-shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed'");

+shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed (but not omitted)'");

// Range

« no previous file with comments | « LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | Source/core/html/HTMLCollection.idl » ('j') | no next file with comments »