Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: Source/core/html/HTMLCollection.idl

Issue 1242233002: The index argument for HTMLCollection item() api should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCollection.idl
diff --git a/Source/core/html/HTMLCollection.idl b/Source/core/html/HTMLCollection.idl
index 85c2d5acb74e618a2c899948fed011e55cac5c1a..b285517acb0dfd89fad3e990acd8a4ddeb6e7203 100644
--- a/Source/core/html/HTMLCollection.idl
+++ b/Source/core/html/HTMLCollection.idl
@@ -27,7 +27,6 @@
WillBeGarbageCollected,
] interface HTMLCollection {
readonly attribute unsigned long length;
- // FIXME: The index argument should not be optional.
- getter Element? item([Default=Undefined] optional unsigned long index);
+ getter Element? item(unsigned long index);
getter Element? namedItem(DOMString name);
};
« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698