Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1242033002: All batches do their own pipeline compare (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

All batches do their own pipeline compare BUG=skia: Committed: https://skia.googlesource.com/skia/+/8cab9a7685e872427e6f0388f149575a9b6016ee

Patch Set 1 #

Patch Set 2 : tidy #

Patch Set 3 : add quick accept to pipeline compare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -6 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrBatch.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +20 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
joshualitt
This trivial CL just moves the comparison of the pipeline to the subclasses of GrBatch ...
5 years, 5 months ago (2015-07-16 14:15:34 UTC) #2
bsalomon
On 2015/07/16 14:15:34, joshualitt wrote: > This trivial CL just moves the comparison of the ...
5 years, 5 months ago (2015-07-16 14:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242033002/40001
5 years, 5 months ago (2015-07-16 16:06:34 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 16:13:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8cab9a7685e872427e6f0388f149575a9b6016ee

Powered by Google App Engine
This is Rietveld 408576698