Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1241733002: Correct bottom overscroll in VariableHeightScrollable (Closed)

Created:
5 years, 5 months ago by hansmuller1
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Correct bottom overscroll in VariableHeightScrollable Also updated the createDefaultScrollSimulation() springConstant and drag parameters to make non-overscroll fling scrolls slowdown faster and overscrolls snap back into place a little more snappily. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/75d1543ef716601fb63daf254ae2428091cd1dd5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M sky/sdk/lib/animation/scroll_behavior.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/variable_height_scrollable.dart View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hansmuller
PTAL
5 years, 5 months ago (2015-07-14 19:02:55 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-14 19:09:33 UTC) #4
Chinmay
https://codereview.chromium.org/1241733002/diff/1/sky/sdk/lib/widgets/scrollable.dart File sky/sdk/lib/widgets/scrollable.dart (right): https://codereview.chromium.org/1241733002/diff/1/sky/sdk/lib/widgets/scrollable.dart#newcode17 sky/sdk/lib/widgets/scrollable.dart:17: // eventVelocity is pixels/second, config min,max limits are pixels/ms ...
5 years, 5 months ago (2015-07-14 20:59:08 UTC) #6
hansmuller
On 2015/07/14 20:59:08, Chinmay wrote: > https://codereview.chromium.org/1241733002/diff/1/sky/sdk/lib/widgets/scrollable.dart > File sky/sdk/lib/widgets/scrollable.dart (right): > > https://codereview.chromium.org/1241733002/diff/1/sky/sdk/lib/widgets/scrollable.dart#newcode17 > ...
5 years, 5 months ago (2015-07-14 22:35:29 UTC) #7
hansmuller1
5 years, 5 months ago (2015-07-14 22:37:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
75d1543ef716601fb63daf254ae2428091cd1dd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698