Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: sky/sdk/lib/widgets/scrollable.dart

Issue 1241733002: Correct bottom overscroll in VariableHeightScrollable (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 6
7 import 'package:newton/newton.dart'; 7 import 'package:newton/newton.dart';
8 import 'package:sky/animation/animated_simulation.dart'; 8 import 'package:sky/animation/animated_simulation.dart';
9 import 'package:sky/animation/scroll_behavior.dart'; 9 import 'package:sky/animation/scroll_behavior.dart';
10 import 'package:sky/theme/view_configuration.dart' as config; 10 import 'package:sky/theme/view_configuration.dart' as config;
11 import 'package:sky/widgets/basic.dart'; 11 import 'package:sky/widgets/basic.dart';
12 12
13 const double _kMillisecondsPerSecond = 1000.0; 13 const double _kMillisecondsPerSecond = 1000.0;
14 14
15 double _velocityForFlingGesture(double eventVelocity) { 15 double _velocityForFlingGesture(double eventVelocity) {
16 // eventVelocity is pixels/second, config min,max limits are pixels/ms
16 return eventVelocity.clamp(-config.kMaxFlingVelocity, config.kMaxFlingVelocity ) / 17 return eventVelocity.clamp(-config.kMaxFlingVelocity, config.kMaxFlingVelocity ) /
17 _kMillisecondsPerSecond; 18 _kMillisecondsPerSecond;
18 } 19 }
19 20
20 abstract class ScrollClient { 21 abstract class ScrollClient {
21 bool ancestorScrolled(Scrollable ancestor); 22 bool ancestorScrolled(Scrollable ancestor);
22 } 23 }
23 24
24 enum ScrollDirection { vertical, horizontal } 25 enum ScrollDirection { vertical, horizontal }
25 26
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 160
160 void _handleFlingCancel(sky.GestureEvent event) { 161 void _handleFlingCancel(sky.GestureEvent event) {
161 settleScrollOffset(); 162 settleScrollOffset();
162 } 163 }
163 164
164 void _handleWheel(sky.WheelEvent event) { 165 void _handleWheel(sky.WheelEvent event) {
165 scrollBy(-event.offsetY); 166 scrollBy(-event.offsetY);
166 } 167 }
167 168
168 } 169 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/animation/scroll_behavior.dart ('k') | sky/sdk/lib/widgets/variable_height_scrollable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698