sky/sdk/lib/widgets/scrollable.dart - Issue 1241733002: Correct bottom overscroll in VariableHeightScrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/scrollable.dart

Issue 1241733002: Correct bottom overscroll in VariableHeightScrollable (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Merge Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/widgets/scrollable.dart

diff --git a/sky/sdk/lib/widgets/scrollable.dart b/sky/sdk/lib/widgets/scrollable.dart

index 1195a6a9b860a0d6bd856cc47ff1bca53bf6c495..6a687b5fa67415f8fcf6c2ad86de2a61cbabc036 100644

--- a/sky/sdk/lib/widgets/scrollable.dart

+++ b/sky/sdk/lib/widgets/scrollable.dart

@@ -13,6 +13,7 @@ import 'package:sky/widgets/basic.dart';

const double _kMillisecondsPerSecond = 1000.0;

double _velocityForFlingGesture(double eventVelocity) {

+ // eventVelocity is pixels/second, config min,max limits are pixels/ms

return eventVelocity.clamp(-config.kMaxFlingVelocity, config.kMaxFlingVelocity) /

_kMillisecondsPerSecond;

}