Issue 1240813002: Revert of win/clang: Roll clang 239674:242130

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1240813002: Revert of win/clang: Roll clang 239674:242130 (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
hans

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of win/clang: Roll clang 239674:242130 (patchset #3 id:40001 of https://codereview.chromium.org/1234713002/) Reason for revert: Looks like this caused http://crbug.com/510555 Original issue's description: > win/clang: Roll clang 239674:242130 > > 32-bit SEH, member pointers with virtual bases, inttypes.h warning fix... > > BUG=509256, 82385 > R=hans@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/2776ee378ee7d309d5d837e1e4405460403556ff TBR=hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509256, 82385 Committed: https://crrev.com/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586 Cr-Commit-Position: refs/heads/master@{#338891}

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -8 lines)			Patch
M	build/common.gypi	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View	1 chunk	+12 lines, -4 lines	0 comments	Download
M	tools/clang/scripts/update.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240813002/1

5 years, 5 months ago (2015-07-15 19:41:03 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-15 19:46:53 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586
Cr-Commit-Position: refs/heads/master@{#338891}