Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: build/common.gypi

Issue 1240813002: Revert of win/clang: Roll clang 239674:242130 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e0eb8d299dbd74e668caa21044a147a142044dde..a0ebbf3564ced5abd48e92fc7e58540d37537308 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2604,9 +2604,6 @@
# TODO(hans): Get this cleaned up, http://crbug.com/428099
'-Wno-inconsistent-missing-override',
-
- # TODO(thakis): Enable this, crbug.com/507717
- '-Wno-shift-negative-value',
],
},
'includes': [ 'set_clang_warning_flags.gypi', ],
@@ -3101,6 +3098,12 @@
['enable_wexit_time_destructors==1 and OS!="win"', {
# TODO: Enable on Windows too, http://crbug.com/404525
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
+ }],
+ ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="239674-1"', {
+ # TODO(thakis): Move this to the global clang_warning_flags block once
+ # clang is rolled far enough that the pinned clang understands this flag
+ # TODO(thakis): Enable this, crbug.com/507717
+ 'variables': { 'clang_warning_flags': ['-Wno-shift-negative-value']},
}],
['chromium_code==0', {
'variables': {
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698