Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1240813002: Revert of win/clang: Roll clang 239674:242130 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/clang/scripts/update.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 ] 909 ]
910 910
911 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost 911 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
912 # always have different versions. Certain flags may not be recognized by 912 # always have different versions. Certain flags may not be recognized by
913 # one version or the other. 913 # one version or the other.
914 if (!is_nacl) { 914 if (!is_nacl) {
915 # Flags NaCl does not recognize. 915 # Flags NaCl does not recognize.
916 default_warning_flags += [ 916 default_warning_flags += [
917 # TODO(hans): Get this cleaned up, http://crbug.com/428099 917 # TODO(hans): Get this cleaned up, http://crbug.com/428099
918 "-Wno-inconsistent-missing-override", 918 "-Wno-inconsistent-missing-override",
919 ]
919 920
920 # TODO(thakis): Enable this, crbug.com/507717 921 if (exec_script("//tools/clang/scripts/update.py",
921 "-Wno-shift-negative-value", 922 [ "--print-revision" ],
922 ] 923 "trim string") != "239674-1") {
924 default_warning_flags += [
925 # TODO(thakis): Move this into outer if once clang is rolled far enough
926 # that the pinned clang understands this flag.
927 # TODO(thakis): Enable this, crbug.com/507717
928 "-Wno-shift-negative-value",
929 ]
930 }
923 } 931 }
924 } 932 }
925 933
926 # chromium_code --------------------------------------------------------------- 934 # chromium_code ---------------------------------------------------------------
927 # 935 #
928 # Toggles between higher and lower warnings for code that is (or isn't) 936 # Toggles between higher and lower warnings for code that is (or isn't)
929 # part of Chromium. 937 # part of Chromium.
930 938
931 config("chromium_code") { 939 config("chromium_code") {
932 if (is_win) { 940 if (is_win) {
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 cflags += [ "-gsplit-dwarf" ] 1243 cflags += [ "-gsplit-dwarf" ]
1236 } 1244 }
1237 } 1245 }
1238 } 1246 }
1239 1247
1240 config("no_symbols") { 1248 config("no_symbols") {
1241 if (!is_win) { 1249 if (!is_win) {
1242 cflags = [ "-g0" ] 1250 cflags = [ "-g0" ]
1243 } 1251 }
1244 } 1252 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | tools/clang/scripts/update.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698