Create nacl_integration.isolate.

Create nacl_integration.isolate.

Do not use it yet.

Remove the code to delete the temporary directory, this can't be done on
Swarming.

R=mseaborn@chromium.org
BUG=98637

[M-A Ruel, 2015-07-13 21:07:27]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2015-07-13 21:13:05]

Hi

As part of https://code.google.com/p/chromium/issues/detail?id=496321 and
ultimately https://code.google.com/p/chromium/issues/detail?id=98637, I've
started to take a look at nacl_integration.

The current show stopper I have is that
native_client/toolchain/pnacl_linux_x86/sysroot/sys-include is an invalid
symlink. isolate doesn't allow invalid symlink. Could this be fixed?

Beside that, I'm also unsure about what needs to be mapped, as the test
currently fails locally.

This patch depends on https://codereview.chromium.org/1241443003.

Thanks

[Mark Seaborn, 2015-07-13 21:26:48]

On 13 July 2015 at 14:13, <maruel@chromium.org> wrote:

> Message:
> Hi
>
> As part of https://code.google.com/p/chromium/issues/detail?id=496321 and
> ultimately https://code.google.com/p/chromium/issues/detail?id=98637, I've
> started to take a look at nacl_integration.
>
> The current show stopper I have is that
> native_client/toolchain/pnacl_linux_x86/sysroot/sys-include is an invalid
> symlink. isolate doesn't allow invalid symlink. Could this be fixed?
>

How come isolate doesn't allow dangling symlinks?

BTW, I haven't got "toolchain/pnacl_linux_x86" locally.  The current layout
is "toolchain/linux_x86/pnacl_newlib".  And I don't see a "sysroot"
directory in my local copy of the toolchain.  Is something horribly out of
date here?

Cheers,
Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-07-13 22:24:18]

On 2015/07/13 21:26:48, Mark Seaborn wrote:
> How come isolate doesn't allow dangling symlinks?

On purpose as a safety measure. But it's an non-issue now;

> BTW, I haven't got "toolchain/pnacl_linux_x86" locally.  The current layout
> is "toolchain/linux_x86/pnacl_newlib".  And I don't see a "sysroot"
> directory in my local copy of the toolchain.  Is something horribly out of
> date here?

I did:
rm -rf native_client/toolchain/
gclient runhooks

and the invalid symlink disappeared. This still means that an indeterminate
amount of stale files will be archived due to old files living outside the out/
directory.

I ran nacl_integration isolated on linux and it returned 0 but printed out
"There are 14 broken tests.". I assume there's something wrong for now.

[M-A Ruel, 2015-07-14 21:16:21]

I cleaned it up a bit. You can try it locally by doing:

git checkout -b nacl origin/master
git cl patch 1240513002
build/gyp_chromium
ninja -C out/Release nacl_integration_run
./tools/swarming_client/isolate.py run -s out/Release/nacl_integration.isolated
-- --output foo.json

--output is required but can't be added in the isolate file.

Note that native_client/ is 1.9Gb so it'd be better to not map the whole thing
but I don't know what is really needed for this test. Help would be appreciated.
Once this file is committed, the recipe needs to be updated to run this test
isolated like other tests.

[M-A Ruel, 2015-07-15 00:33:57]

Patchset #2 (id:40001) has been deleted