Issue 1241443003: Add mesa dependency to target chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1241443003: Add mesa dependency to target chrome. (Closed)

Created:
5 years, 5 months ago by M-A Ruel

Modified:
5 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add mesa dependency to target chrome. Since chrome.isolate import mesa dynamic libraries, the target itself should be properly dependent. This arises with nacl_integration, which only builds chrome and nothing else. R=jam@chromium.org BUG=98637

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/chrome_exe.gypi	View		1 chunk	+4 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1240513002 Patch 20001

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Captain' obvious fixing the patch. Please hold on review.

5 years, 5 months ago (2015-07-13 21:13:29 UTC) #2

M-A Ruel

On 2015/07/13 21:13:29, M-A Ruel wrote: > Captain' obvious fixing the patch. Please hold on ...

5 years, 5 months ago (2015-07-13 21:15:04 UTC) #3

jam

This is only used for testing, i.e. it's not in shipping chrome builds. see https://code.google.com/p/chromium/codesearch#chromium/src/content/public/test/browser_test_base.cc&rcl=1436599777&l=244 ...

5 years, 5 months ago (2015-07-14 15:40:07 UTC) #4

M-A Ruel

5 years, 5 months ago (2015-07-14 20:05:15 UTC) #5

On 2015/07/14 15:40:07, jam wrote:
> This is only used for testing, i.e. it's not in shipping chrome builds. see
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...
> which forces it on (depending on platform blah blah) for browser tests

Abandoning this CL, I'll add the dependency to nacl_integration_run instead.

Expand Messages | Collapse Messages