Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8435)

Unified Diff: chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py

Issue 1240513002: Create nacl_integration.isolate. Base URL: https://chromium.googlesource.com/a/chromium/src.git@4_chrome
Patch Set: Cleaned up Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/nacl_integration.isolate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py
diff --git a/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py b/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py
index 16af0441b9e4adbbf6dc53f6c2b5d703e4c194d3..7ee5011b6aa0c2e4196ff23aee43e51d365a87c4 100755
--- a/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py
+++ b/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py
@@ -56,27 +56,6 @@ def TryToCleanPath(path, file_name_filter=lambda fn: True):
print 'Skipping %s' % path
-# TODO(ncbray): this is somewhat unsafe. We should fix the underlying problem.
-def CleanTempDir():
- # Only delete files and directories like:
- # a) C:\temp\83C4.tmp
- # b) /tmp/.org.chromium.Chromium.EQrEzl
- file_name_re = re.compile(
- r'[\\/]([0-9a-fA-F]+\.tmp|\.org\.chrom\w+\.Chrom\w+\..+)$')
- file_name_filter = lambda fn: file_name_re.search(fn) is not None
-
- path = os.environ.get('TMP', os.environ.get('TEMP', '/tmp'))
- if len(path) >= 4 and os.path.isdir(path):
- print
- print "Cleaning out the temp directory."
- print
- TryToCleanContents(path, file_name_filter)
- else:
- print
- print "Cannot find temp directory, not cleaning it."
- print
-
-
def RunCommand(cmd, cwd, env):
sys.stdout.write('\nRunning %s\n\n' % ' '.join(cmd))
sys.stdout.flush()
@@ -235,8 +214,6 @@ def BuildAndTest(options):
cmd.append('json_build_results_output_file=%s' %
options.json_build_results_output_file)
- CleanTempDir()
-
if options.enable_newlib:
RunTests('nacl-newlib', cmd, env)
« no previous file with comments | « chrome/nacl_integration.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698