Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1240353002: ozone: rename to GpuMemoryBuffer(Factory|Impl)OzoneNativePixmap. (Closed)

Created:
5 years, 5 months ago by dshwang
Modified:
5 years, 5 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: rename to GpuMemoryBuffer(Factory|Impl)OzoneNativePixmap. GpuMemoryBuffer(Factory|Impl)OzoneNativeBuffer eventually creates NativePixmap, so rename them to GpuMemoryBuffer(Factory|Impl)OzoneNativePixmap. BUG=475633 Committed: https://crrev.com/6a80cc0d45f2f51dd4604ef2f78473e43786eb6c Cr-Commit-Position: refs/heads/master@{#340258}

Patch Set 1 #

Patch Set 2 : rename OZONE_NATIVE_BUFFER to OZONE_NATIVE_PIXMAP #

Total comments: 2

Patch Set 3 : address nits in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -693 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc View 1 chunk +0 lines, -56 lines 0 comments Download
A + content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
A + content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 1 1 chunk +12 lines, -14 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
D content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 chunk +0 lines, -95 lines 0 comments Download
A + content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 4 chunks +18 lines, -21 lines 0 comments Download
M content/common/gpu/media/vaapi_drm_picture.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/demo/surfaceless_gl_renderer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/demo/surfaceless_gl_renderer.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/gpu/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 chunk +0 lines, -260 lines 0 comments Download
A + ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M ui/ozone/gpu/ozone_gpu.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
dshwang
reveman, could you review? reveman request to rename NativePixmap to NativeBuffer in https://codereview.chromium.org/1134993003/#msg16 However, the ...
5 years, 5 months ago (2015-07-20 17:22:07 UTC) #2
spang
lgtm
5 years, 5 months ago (2015-07-20 18:12:13 UTC) #3
reveman
lgtm
5 years, 5 months ago (2015-07-20 20:07:55 UTC) #4
dshwang
thank you for reviewing. nasko, could you review content/browser/gpu, and content/common/gpu/client?
5 years, 5 months ago (2015-07-21 10:05:11 UTC) #6
nasko
There are more specific OWNERs for GPU code (content/common/gpu/OWNERS, content/browser/gpu/OWNERS). Please use those, as I ...
5 years, 5 months ago (2015-07-21 11:27:25 UTC) #7
dshwang
sievers, could you review content/browser/gpu, and content/common/gpu/client?
5 years, 5 months ago (2015-07-21 11:48:15 UTC) #10
dshwang
On 2015/07/21 11:48:15, dshwang wrote: > sievers, could you review content/browser/gpu, and content/common/gpu/client? sievers, could ...
5 years, 5 months ago (2015-07-22 14:48:56 UTC) #11
reveman
Please change the name of gfx::GpuMemoryBufferType::OZONE_NATIVE_BUFFER to gfx::GpuMemoryBufferType::OZONE_NATIVE_PIXMAP as part of this change.
5 years, 5 months ago (2015-07-22 19:47:39 UTC) #12
dshwang
On 2015/07/22 19:47:39, reveman wrote: > Please change the name of gfx::GpuMemoryBufferType::OZONE_NATIVE_BUFFER to > gfx::GpuMemoryBufferType::OZONE_NATIVE_PIXMAP ...
5 years, 5 months ago (2015-07-23 08:26:55 UTC) #13
no sievers
lgtm https://codereview.chromium.org/1240353002/diff/20001/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h (right): https://codereview.chromium.org/1240353002/diff/20001/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h#newcode12 content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h:12: // Implementation of GPU memory buffer based on ...
5 years, 5 months ago (2015-07-23 18:10:39 UTC) #14
dshwang
Thank you for reviewing! addressed nits. https://codereview.chromium.org/1240353002/diff/20001/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h (right): https://codereview.chromium.org/1240353002/diff/20001/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h#newcode12 content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h:12: // Implementation of ...
5 years, 5 months ago (2015-07-24 10:34:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1240353002/40001
5 years, 5 months ago (2015-07-24 10:34:52 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-24 11:55:19 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 11:55:55 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a80cc0d45f2f51dd4604ef2f78473e43786eb6c
Cr-Commit-Position: refs/heads/master@{#340258}

Powered by Google App Engine
This is Rietveld 408576698