Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, dgrogan, adamk+blink_chromium.org, rwlbuis, jamesr, krit, dsinclair, alecflett, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, gavinp+loader_chromium.org, pdr., nessy, loislo+blink_chromium.org, sof, jbroman, feature-media-reviews_chromium.org, Nate Chapin, vcarbune.chromium, philipj_slow, jsbell, gasubic, cmumford, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() first. These methods just proxy the calls to the internal String member. R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -39 lines) Patch
M Source/core/dom/Node.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/events/GenericEventQueue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextBreakIteratorICU.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextBreakIteratorInternalICU.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/text/AtomicString.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/wtf/text/WTFString.h View 3 chunks +9 lines, -8 lines 0 comments Download
M Source/wtf/text/WTFString.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 11 months ago (2014-01-03 20:12:24 UTC) #1
abarth-chromium
How should we decide which functions to forward and which require a call to string() ...
6 years, 11 months ago (2014-01-03 20:24:51 UTC) #2
eseidel
IMO we should just have STring and AtomicString share a template base class. OR consider ...
6 years, 11 months ago (2014-01-03 23:40:05 UTC) #3
eseidel
lgtm, but please make sure abarth is happy as well before landing.
6 years, 11 months ago (2014-01-03 23:40:56 UTC) #4
abarth-chromium
Oh, I'm happy with this change. I was just curious where to draw the line.
6 years, 11 months ago (2014-01-04 02:55:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/124003003/1
6 years, 11 months ago (2014-01-04 05:22:11 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-04 06:52:21 UTC) #7
Message was sent while issue was closed.
Change committed as 164482

Powered by Google App Engine
This is Rietveld 408576698