Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1873)

Unified Diff: Source/web/tests/TouchActionTest.cpp

Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/text/TextBreakIteratorInternalICU.cpp ('k') | Source/wtf/text/AtomicString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/TouchActionTest.cpp
diff --git a/Source/web/tests/TouchActionTest.cpp b/Source/web/tests/TouchActionTest.cpp
index e2a0aa3f0c99dec462a3c3dbcada840edad3be13..695d18a9193bfeecf8ef69726906bcea94f1905f 100755
--- a/Source/web/tests/TouchActionTest.cpp
+++ b/Source/web/tests/TouchActionTest.cpp
@@ -189,7 +189,7 @@ void TouchActionTest::runTestOnTree(WebCore::Node* root, WebView* webView, Touch
std::string failureContext("Test case: ");
if (element->hasID()) {
- failureContext.append(element->getIdAttribute().string().ascii().data());
+ failureContext.append(element->getIdAttribute().ascii().data());
} else if (element->firstChild()) {
failureContext.append("\"");
failureContext.append(element->firstChild()->textContent(false).stripWhiteSpace().ascii().data());
@@ -269,7 +269,7 @@ void TouchActionTest::runTestOnTree(WebCore::Node* root, WebView* webView, Touch
} else if (expectedAction == "pan-x-y") {
EXPECT_EQ((WebTouchActionPanX | WebTouchActionPanY), client.lastTouchAction()) << failureContextPos;
} else {
- FAIL() << "Unrecognized expected-action \"" << expectedAction.string().ascii().data()
+ FAIL() << "Unrecognized expected-action \"" << expectedAction.ascii().data()
<< "\" " << failureContextPos;
}
}
« no previous file with comments | « Source/platform/text/TextBreakIteratorInternalICU.cpp ('k') | Source/wtf/text/AtomicString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698